Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Capitalized e2e test action name #1494

Merged
merged 2 commits into from
Dec 11, 2023
Merged

refactor: Capitalized e2e test action name #1494

merged 2 commits into from
Dec 11, 2023

Conversation

neitdung
Copy link
Contributor

Description

Closes: #1322

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • Confirmed all author checklist items have been addressed

@neitdung neitdung requested a review from a team as a code owner December 11, 2023 10:52
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Dec 11, 2023
MSalopek
MSalopek approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

LGTM.

p-offtermatt
p-offtermatt approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@p-offtermatt p-offtermatt added this pull request to the merge queue Dec 11, 2023
Merged via the queue into cosmos:main with commit 8a5932d Dec 11, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees
No one assigned
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent action names
3 participants
@neitdung @MSalopek @p-offtermatt