Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: updating some workflows and preparing for merge queues #1464

Merged
merged 9 commits into from
Dec 5, 2023
Merged

ci: updating some workflows and preparing for merge queues #1464

merged 9 commits into from
Dec 5, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Dec 1, 2023

Description

Closes: NA

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@mpoke mpoke requested a review from a team as a code owner December 1, 2023 11:16
@github-actions github-actions bot added C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler labels Dec 1, 2023
@mpoke mpoke mentioned this pull request Dec 1, 2023
Closed
12 tasks
p-offtermatt
p-offtermatt approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about the link checker, everything else looks ok.

.github/workflows/md-link-checker.yml
name: Check Markdown links
on:
pull_request:
paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on #1461 already about this workflow, let's discuss there

@mpoke mpoke mentioned this pull request Dec 5, 2023
Closed
8 tasks
MSalopek
MSalopek approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not sure how we can test changes like this without risking breaking something in the CI - that's unfortunate but it is what it is.

@mpoke mpoke merged commit 164facb into main Dec 5, 2023
10 checks passed
@mpoke mpoke deleted the marius/gh-actions branch December 5, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees
No one assigned
Labels
C:Build Assigned automatically by the PR labeler C:CI Assigned automatically by the PR labeler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpoke @MSalopek @p-offtermatt