Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto-fill of gov address for provider 'draft-proposal' #1444

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

bermuell
Copy link
Contributor

@bermuell bermuell commented Nov 23, 2023

Description

Closes: #1378

Fix related to #1408 and #1379
Generating a draft proposalfor provider messages does not auto-fill the address of the governance module.
This is due to a naming assumption on the SDK module where the filed of the signing address has to be named "authority".
Re-naming field from 'signer' to 'authority' in the proposal messages of provider fixes this issue.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if state-machine breaking change (i.e., requires coordinated upgrade)
  • Confirmed this PR does not introduce changes requiring state migrations, OR migration code has been added to consumer and/or provider modules
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed
  • If this PR is library API breaking, bump the go.mod version string of the repo, and follow through on a new major release

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed this PR does not introduce changes requiring state migrations, OR confirmed migration code has been added to consumer and/or provider modules
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@github-actions github-actions bot added the C:x/provider Assigned automatically by the PR labeler label Nov 23, 2023
@bermuell bermuell marked this pull request as ready for review November 23, 2023 13:46
@bermuell bermuell requested a review from a team as a code owner November 23, 2023 13:46
@bermuell bermuell self-assigned this Nov 23, 2023
@bermuell bermuell requested a review from MSalopek November 23, 2023 13:46
@bermuell bermuell changed the title fix: Fix auto-fill of gov address for provider 'draft-proposal' fix: auto-fill of gov address for provider 'draft-proposal' is broken Nov 23, 2023
@bermuell bermuell changed the title fix: auto-fill of gov address for provider 'draft-proposal' is broken fix: auto-fill of gov address for provider 'draft-proposal' Nov 23, 2023
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@bermuell bermuell merged commit 1819e73 into feat/v50-upgrade Nov 23, 2023
3 of 12 checks passed
@bermuell bermuell deleted the bernd/1378-fix_proposal_messages branch November 23, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/provider Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants