Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix relayer/consensus discrepancy for throttle v2 e2e test #1298

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Sep 13, 2023

Description

Handles a discrepancy with how packets are relayed between gorelayer and hermes in e2e tests for throttling v2.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@shaspitz shaspitz requested a review from a team as a code owner September 13, 2023 22:16
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Sep 13, 2023
@shaspitz
Copy link
Contributor Author

Now passes both go run ./tests/e2e/... --tc slash-throttle and go run ./tests/e2e/... --tc slash-throttle --use-cometmock --use-gorelayer 👍

@shaspitz shaspitz changed the title tests: relayer discrepancy handling for throttle v2 e2e test tests: fix relayer/consensus discrepancy for throttle v2 e2e test Sep 14, 2023
@shaspitz
Copy link
Contributor Author

Closing in favor of being happy with just the comet flavor of the throttling e2e test. Discrepancy tracked in #1304

@shaspitz shaspitz closed this Sep 14, 2023
@shaspitz shaspitz deleted the shawn/relayer-discrepancy-handling branch September 14, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant