-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consumer throttle state query #1285
Merged
shaspitz
merged 49 commits into
feat/throttle-complete-attempt-2
from
shawn/consumer-throttle-state-query
Sep 18, 2023
Merged
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
7691bf5
wip, tests not fixed yet
shaspitz a10a239
rm packet query on provider
shaspitz 8a557b3
rm unneeded UTs
shaspitz 196ce38
rm tests from relay_test
shaspitz 0f27c31
rm query and more tests
shaspitz cf09f5f
rm more tests
shaspitz 87ad0f4
Merge branch 'main' into shawn/throttle-with-retries-provider-changes
shaspitz 7e6264f
builds again and rm debug tests
shaspitz 5e4b845
lint
shaspitz 8350956
fix handling of slash packet and integration test
shaspitz 6d20dd1
Fix TestMultiConsumerSlashPacketThrottling
shaspitz 461878c
fix two more slashing integration tests
shaspitz 56242a6
Update TestSlashRetries, cleanup neededc
shaspitz 1d963fa
cleaned up TestSlashRetries
shaspitz e8acd9e
UT for TestOnRecvDowntimeSlashPacket
shaspitz 8ed33f3
cleans
shaspitz ecac6a4
use helper in throttle test
shaspitz f6d4650
lintz
shaspitz 956e595
Revert "rm packet query on provider"
shaspitz db8dc1b
cmd file too
shaspitz 78a8269
fully restore query
shaspitz 73db33b
Merge branch 'main' into shawn/throttle-with-retries-provider-changes
shaspitz 5bfccc3
Revert "Merge branch 'main' into shawn/throttle-with-retries-provider…
shaspitz 5196394
make e2e test pass, with todos
shaspitz 37e0e93
clean
shaspitz b1cb354
Revert "Revert "Merge branch 'main' into shawn/throttle-with-retries-…
shaspitz 599854a
lint
shaspitz 8945156
Update CHANGELOG.md
shaspitz 0544fd3
slightly longer buffer
shaspitz d8f5690
merge main
shaspitz f91cb70
build(deps): bump actions/checkout from 3 to 4 (#1257)
dependabot[bot] aca8362
build(deps)!: bump github.com/cosmos/ibc-go/v7 from 7.2.0 to 7.3.0 (#…
dependabot[bot] 66adc8a
build(deps): bump github.com/cosmos/cosmos-sdk from 0.47.4 to 0.47.5 …
dependabot[bot] cc9064d
chore: Separate semver (#1217)
shaspitz 6da7fef
docs: cleanup changelog (#1260)
mpoke 840d290
fix!: validate MsgTransfer before calling Transfer() (#1244)
mpoke 8ec7bc5
docs: Create adr-012-separate-releasing.md (#1229)
shaspitz b152c03
fix: remove addr validation for provider fee pool addr param (#1262)
NeverHappened 6bdfff9
Merge branch 'main' into shawn/throttle-with-retries-provider-changes
shaspitz 3b27006
Revert "Merge branch 'main' into shawn/throttle-with-retries-provider…
shaspitz afa32f4
Merge branch 'feat/throttle-complete-attempt-2' into shawn/throttle-w…
shaspitz 6ee88e2
fmt
shaspitz c956441
protobuf gen
shaspitz 280e854
impl query resp
shaspitz 688fd8a
add query assertion to e2e tests
shaspitz 000d4a5
Merge branch 'feat/throttle-complete-attempt-2' into shawn/consumer-t…
shaspitz 8d50918
lint
shaspitz 3ea0cf4
add consumer to pending packets name
shaspitz 6e4768e
add panic for invalid bytes
shaspitz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add validation logic here? I'd be worried this could break in "interesting" ways.
From the gjson documentation on the Get function https://godocs.io/github.com/tidwall/gjson#Get:
"This function expects that the json is well-formed, and does not validate. Invalid json will not panic, but it may return back unexpected results. If you are consuming JSON from an unpredictable source then you may want to use the Valid function first. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup seems reasonable to panic when
valid
returns false for the json 👍 6e4768e