Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implement JSON trace format (#878) #1243

Closed
wants to merge 1 commit into from

Conversation

p-offtermatt
Copy link
Contributor

  • Start drafting the test trace parser

Restructure folder for testdata

Remove ITF writer and start with JSONWriter

  • Make action and state exported fields

  • Chore: Make all fields of actions exported

Chore: make config fields exported

  • Chore: Map actionType strings to action structs

  • Refactor trace handler

Marshal Steps with ActionTypes

Debug first version of JSON writer/reader

Remove parser testinputs

Remove outdated package

Tidy go mod

Remove output folder

Resort go.mod

Fix WriteFile call to put low permissions

Inline error check

Improve comments

Add test that writes traces to permanent directory

  • Add example traces and test files

Add folder with test traces

Add dedicated folder for input traces

Please go the the Preview tab and select the appropriate sub-template:

  • Production code - for types fix, feat, and refactor.
  • Docs - for documentation changes.
  • Others - for changes that do not affect production code.

* Start drafting the test trace parser

Restructure folder for testdata

Remove ITF writer and start with JSONWriter

* Make action and state exported fields

* Chore: Make all fields of actions exported

Chore: make config fields exported

* Chore: Map actionType strings to action structs

* Refactor trace handler

Marshal Steps with ActionTypes

Debug first version of JSON writer/reader

Remove parser testinputs

Remove outdated package

Tidy go mod

Remove output folder

Resort go.mod

Fix WriteFile call to put low permissions

Inline error check

Improve comments

Add test that writes traces to permanent directory

* Add example traces and test files

Add folder with test traces

Add dedicated folder for input traces
@p-offtermatt p-offtermatt linked an issue Aug 25, 2023 that may be closed by this pull request
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Aug 25, 2023
@p-offtermatt p-offtermatt changed the title features: Implement JSON trace format (#878) chore: Implement JSON trace format (#878) Aug 25, 2023
@p-offtermatt p-offtermatt linked an issue Aug 25, 2023 that may be closed by this pull request
@p-offtermatt
Copy link
Contributor Author

Closed in favor of #1265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the e2e framework to take traces as an input Refactor existing e2e tests to take traces as inputs
1 participant