Skip to content

Commit

Permalink
nits
Browse files Browse the repository at this point in the history
  • Loading branch information
sainoe committed Mar 18, 2024
1 parent ad0b37a commit 3a64ebe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions tests/e2e/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ func generateImageName(version string, cfg TargetConfig) (string, error) {
tagName = "local" // this refers to build from local workspace
} else {
// use git hash of rev as docker image tag

cmd := exec.Command("git", "log", "--pretty=format:%h", "-n", "1", version)
out, err := cmd.CombinedOutput()
if err != nil {
Expand Down Expand Up @@ -179,7 +178,7 @@ func pullDockerImage(tag string, targetConfig TargetConfig) (string, error) {
// bootstrapSDK in workspace to use custom SDK setup if required
func bootstrapSDK(workSpace string, targetCfg TargetConfig) error {
sdkPath := strings.Join([]string{workSpace, "cosmos-sdk"}, string(os.PathSeparator))
err := os.RemoveAll(sdkPath) //delete old SDK directory

if err != nil {

Check failure on line 182 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-cometmock

undefined: err

Check failure on line 182 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-e2e

undefined: err

Check failure on line 182 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-e2e-compatibility

undefined: err

Check failure on line 182 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-trace

undefined: err
return fmt.Errorf("error deleting SDK directory from workspace: %v", err)

Check failure on line 183 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-cometmock

undefined: err

Check failure on line 183 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-e2e

undefined: err

Check failure on line 183 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-e2e-compatibility

undefined: err

Check failure on line 183 in tests/e2e/builder.go

View workflow job for this annotation

GitHub Actions / test-trace

undefined: err
}
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/test_target.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type ExecutionTarget interface {
type DockerContainer struct {
targetConfig TargetConfig
containerCfg ContainerConfig
images []string //images needed to build the target container

ImageName string
}

Expand Down

0 comments on commit 3a64ebe

Please sign in to comment.