chore: use context.Context and appmodule.Environment in 08-wasm #7880
Conversation
technicallyty
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
|
|
||
| func moduleLogger(ctx sdk.Context) log.Logger { | ||
| return ctx.Logger().With("module", "x/"+exported.ModuleName+"-"+types.ModuleName) | ||
| func (k Keeper) Logger(_ context.Context) log.Logger { |
There was a problem hiding this comment.
Is the context still there due to some interface that needs to be satisifed?
There was a problem hiding this comment.
oops. i should have removed it. done in remove context argument from logger method
updated the queriers! |
| @@ -146,7 +149,7 @@ func AcceptListStargateQuerier(acceptedQueries []string, queryRouter types.Query | |||
| return nil, wasmvmtypes.UnsupportedRequest{Kind: fmt.Sprintf("No route to query '%s'", request.Path)} | |||
| } | |||
|
|
|||
| res, err := route(ctx, &abci.QueryRequest{ | |||
| res, err := route(sdk.UnwrapSDKContext(ctx), &abci.QueryRequest{ | |||
There was a problem hiding this comment.
Out of curiosity, why is GRPCQueryHandler still taking an sdk context?
There was a problem hiding this comment.
so this uses the baseapp query handler directly, which still takes sdk.Context. I did try to update it to use the Environment's query handler however,
the Environment query handler returns a transaction.Msg, (a gogoproto message type) instead of bytes, which would change the custom query return type, unless i marshalled the msg but.... i don't actually know what the encoding is for those bytes returned from the baseapp version. i assume its proto encoded, but im not 100% on that. :C
| @@ -99,7 +99,7 @@ func (ws *WasmSnapshotter) RestoreExtension(height uint64, format uint32, payloa | |||
| return errorsmod.Wrapf(snapshot.ErrUnknownFormat, "expected %d, got %d", ws.SnapshotFormat(), format) | |||
| } | |||
|
|
|||
| func restoreV1(ctx sdk.Context, k *Keeper, compressedCode []byte) error { | |||
| func restoreV1(_ sdk.Context, k *Keeper, compressedCode []byte) error { | |||
There was a problem hiding this comment.
Could we remove the sdk.Context entierly here?
There was a problem hiding this comment.
ah yes, removed here remove sdk.Context and height args from WasmSnapshotter functionality.
note this also ended up removing an unused height argument, changing the RestoreExtension method signature
There was a problem hiding this comment.
nvm, just removing context 😅, not height arg. restore height arg because thats an iface impl
|
Description
stacked PR of #7866
supercedes: #7836
Closes: #7712
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.