Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update adr 001 #7783

Open
wants to merge 1 commit into
base: feat/ibc-eureka
Choose a base branch
from
Open

chore: update adr 001 #7783

wants to merge 1 commit into from

Conversation

Sruthi2357
Copy link

Closes: #6537

gjermundgaraba
gjermundgaraba requested changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sruthi2357, thanks for the PR!

The update of ADR-001 requires some more changes as the fields and logic has changed quite significantly. I suggest you take a look at the protobuf, and denom implementation and then spend some time making sure the whole of the ADR is correct with the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba requested changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@srdtrk srdtrk Awaiting requested review from srdtrk srdtrk is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sruthi2357 @gjermundgaraba