Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create 08-wasm-light-clients structure #7603

Closed
wants to merge 6 commits into from
+8,052 −0
Closed

feat: create 08-wasm-light-clients structure #7603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b905769
feat: create 08-wasm-light-clients structure
gjermundgaraba Nov 26, 2024
637f152
set target on correct job
gjermundgaraba Nov 26, 2024
0786d81
Update modules/light-clients/08-wasm-light-clients/Cargo.toml
gjermundgaraba Nov 27, 2024
3868396
Update modules/light-clients/08-wasm-light-clients/contracts/ethereum…
gjermundgaraba Nov 27, 2024
f8ad053
Update modules/light-clients/08-wasm-light-clients/Cargo.toml
gjermundgaraba Nov 27, 2024
6696ceb
code review cleanups
gjermundgaraba Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/wasm-light-clients.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
name: Wasm Light Clients
# This workflow runs when a PR is opened that targets code that is part of the 08-wasm-light-clients
on:
merge_group:
pull_request:
push:
branches:
- main
- feat/ibc-eureka # TODO: Remove before merging to main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should have it's own feature branch and not be merged directly to feat/ibc-eureka in my opinion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible to get things merged in smaller increments, it will be easier than having to maintain yet another feature branch. I would prefer to avoid another branch if smaller PRs can do the job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible to get things merged in smaller increments, it will be easier than having to maintain yet another feature branch. I would prefer to avoid another branch if smaller PRs can do the job

Having been dealing with multiple feature branches for a while now, I 100% agree!

permissions:
contents: read
pull-requests: read

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install stable toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
components: rustfmt, clippy

- name: Lint 08-wasm-light-clients workspace
run: make lint-wasm-light-clients


build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install stable toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
components: rustfmt, clippy
target: wasm32-unknown-unknown

- name: Cargo build 08-wasm-light-clients workspace
run: make build-wasm-light-clients

tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Install stable toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
components: rustfmt, clippy

- name: Unit test 08-wasm-light-clients workspace
run: make test-wasm-light-clients
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,7 @@ go.work.sum

# Python
venv

# Rust
target
artifacts
15 changes: 15 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ build-docker-wasm:

.PHONY: build-docker-wasm

build-wasm-light-clients:
cd modules/light-clients/08-wasm-light-clients && cargo build --release --lib --target wasm32-unknown-unknown

.PHONY: build-wasm-light-clients

###############################################################################
### Tools & Dependencies ###
###############################################################################
Expand Down Expand Up @@ -310,6 +315,11 @@ benchmark:
@go test -mod=readonly -bench=. $(PACKAGES_NOSIMULATION)
.PHONY: benchmark

test-wasm-light-clients:
cd modules/light-clients/08-wasm-light-clients && cargo test

.PHONY: test-wasm-light-clients

###############################################################################
### Linting ###
###############################################################################
Expand Down Expand Up @@ -351,6 +361,11 @@ docs-link-check:

.PHONY: lint lint-fix docs-lint docs-lint-fix docs-link-check

lint-wasm-light-clients:
cd modules/light-clients/08-wasm-light-clients && cargo fmt -- --check && cargo clippy

.PHONY: lint-wasm-light-clients

###############################################################################
### Protobuf ###
###############################################################################
Expand Down
Loading
Loading