refactor: ibc core runtime env #7601
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -182,7 +182,7 @@ | |||
|
|
|||
| // BeginBlock returns the begin blocker for the ibc module. | |||
| func (am AppModule) BeginBlock(ctx context.Context) error { | |||
| ibcclient.BeginBlocker(sdk.UnwrapSDKContext(ctx), am.keeper.ClientKeeper) | |||
| ibcclient.BeginBlocker(ctx, am.keeper.ClientKeeper) | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| @@ -415,10 +386,10 @@ func (k *Keeper) RecvPacket(goCtx context.Context, msg *channeltypes.MsgRecvPack | |||
| writeFn() | |||
There was a problem hiding this comment.
For RecvPacket see #7752
| @@ -208,8 +208,9 @@ func (chain *TestChain) GetContext() sdk.Context { | |||
| headerInfo := header.Info{ | |||
There was a problem hiding this comment.
I have a PR to sdk which can remove this. This stuff should all be set in baseapp test_helpers NewUncachedContext which we use above
There was a problem hiding this comment.
Just needs dependency bump and this could be removed
damiannolan
requested review from
AdityaSripal,
srdtrk and
gjermundgaraba
as code owners
|
I think I have a few follow up commits to address tomorrow, but publishing r4r. The recvPacket issue is pushed to a different PR. We could just remove the error prefixed events... but I think they were requested before for dev ex |
| // TODO: In order to fully migrate away from sdk.Context here we will need to depend on comet service in order | ||
| // to consume the full block header as Env only contains header.Info (where we cannot access next vals hash) |
| func (k *Keeper) SubmitMisbehaviour(goCtx context.Context, msg *clienttypes.MsgSubmitMisbehaviour) (*clienttypes.MsgSubmitMisbehaviourResponse, error) { //nolint:staticcheck // for now, we're using msgsubmitmisbehaviour. | ||
| ctx := sdk.UnwrapSDKContext(goCtx) | ||
|
|
||
| func (k *Keeper) SubmitMisbehaviour(ctx context.Context, msg *clienttypes.MsgSubmitMisbehaviour) (*clienttypes.MsgSubmitMisbehaviourResponse, error) { //nolint:staticcheck // for now, we're using msgsubmitmisbehaviour. |
There was a problem hiding this comment.
nolint can probs be removed here
| @@ -208,8 +208,9 @@ func (chain *TestChain) GetContext() sdk.Context { | |||
| headerInfo := header.Info{ | |||
There was a problem hiding this comment.
Just needs dependency bump and this could be removed
|
Description
ref: #7712
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.