Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename GetValsAtHeight to GetTrustedValidators #5831

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #4484

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

testing/chain.go Outdated Show resolved Hide resolved
@colin-axner colin-axner enabled auto-merge (squash) February 14, 2024 14:55
@colin-axner colin-axner disabled auto-merge February 15, 2024 10:27
@colin-axner colin-axner merged commit 53c7a1a into main Feb 15, 2024
68 checks passed
@colin-axner colin-axner deleted the colin/4484-get-trusted-vals branch February 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix revision height used for trusted validator set queries
3 participants