-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop 32 bit arm support #4682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdk does test against it, the main rationale for dropping it was 08-wasm and wasmVM which flat out doesn't support it, since that will be separate go mod though we could still keep it for ibc-go. Either way, fine with dropping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly in favour of closing this PR after hearing @DimitrisJim
thanks for this @faddat! but i guess I don't really see why keeping arm32 support in for our code/framework is necessarily a bad thing at this point, there hasn't been a huge increased overhead for our team i think. support just closing this PR! |
Soooooo +1 to @DimitrisJim -- I knew about this issue due to years of trying to run tendermint on raspberry pi while those were 32 bit or were 64 bit but had only 32 bit oses. I suppose that if we can get a build running with 32 bit, then we are all set. To my knowledge, we will run into arm and 32 bit issues with wasmvm in our stack now. Feel free to close, if desired to close though. |
Closing for now since the SDK does test against it. Wasm is not a requirement for ibc-go. We can reopen if SDK stops testing against this or it causes us other problems. |
Description
The "Tendermint in production" documentation states that we should not use 32 bit arm, or 32 bit CPUs generally.
https://docs.tendermint.com/v0.34/tendermint-core/running-in-production.html#validator-signing-on-32-bit-architectures-or-arm
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.