E2E Upgrade Part 2 - Human Readable IBC Denom #4649
Conversation
…://github.com/cosmos/ibc-go into cian/issue#4216-add-v7-to-v8-e2e-upgrade-test
…n/issue#4645-v7-to-v8-upgrade-test-part-2
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
DimitrisJim
as code owners
| @@ -103,6 +103,10 @@ func (s *TransferTestSuite) TestMsgTransfer_Succeeds_Nonincentivized() { | |||
|
|
|||
| expected := testvalues.IBCTransferAmount | |||
| s.Require().Equal(expected, actualBalance.Int64()) | |||
|
|
|||
| if testvalues.HumanReadableDenomFeatureReleases.IsSupported(chainBVersion) { | |||
| s.AssertHumanReadableDenom(ctx, chainB, chainADenom, channelA) | |||
There was a problem hiding this comment.
I put together both assertions (check metadata is stored, check that balance returns the human readable denom). I hope that's ok, @chatton.
e2e/testvalues/values.go
Outdated
| @@ -108,3 +108,8 @@ var LocalhostClientFeatureReleases = semverutil.FeatureReleases{ | |||
| "v7.1", | |||
| }, | |||
| } | |||
|
|
|||
| // HumanReadableDenomFeatureReleases represents the releases the human readable denom feature was released in. | |||
| var HumanReadableDenomFeatureReleases = semverutil.FeatureReleases{ | |||
There was a problem hiding this comment.
could also call this DenomMetadataFeatureReleases might be the tiniest bit less wordy, but whatever, happy with this too!
There was a problem hiding this comment.
I'll maybe do the rename in #4660 to avoid needing to do a full re-run of the upgrades here!
There was a problem hiding this comment.
nvm the upgrade test failed anyway :D
|
@damiannolan, I accidentally reverted a change I made previously. I updated the test to upgrade chain B (so we can test for the denom on chain B based on how we did the ibc transfer) |
| @@ -394,3 +383,30 @@ func (s *E2ETestSuite) QueryGranterGrants(ctx context.Context, chain *cosmos.Cos | |||
|
|
|||
| return grants.Grants, nil | |||
| } | |||
|
|
|||
| // QueryBalances returns all the balances on the given chain for the provided address. | |||
| func (s *E2ETestSuite) QueryAllBalances(ctx context.Context, chain ibc.Chain, address string, resolveDenom bool) (sdk.Coins, error) { | |||
There was a problem hiding this comment.
I moved this down here to keep both usages of the bank query client together.
e2e/testvalues/values.go
Outdated
| @@ -48,11 +48,6 @@ func SolomachineClientID(id int) string { | |||
| return fmt.Sprintf("06-solomachine-%d", id) | |||
| } | |||
|
|
|||
| // TokenMetadataFeatureReleases represents the releases the token metadata was released in. | |||
| var TokenMetadataFeatureReleases = semverutil.FeatureReleases{ | |||
There was a problem hiding this comment.
Deleted this and used the one @chatton added.
There was a problem hiding this comment.
whoops I missed this and deleted the one I added and use the one you used 😄
| @@ -71,7 +71,7 @@ jobs: | |||
| chain-binary: simd | |||
| chain-a-tag: v7.0.0 | |||
| chain-b-tag: v7.0.0 | |||
| chain-upgrade-tag: pr-4591 # TODO: update this to a real tag once v8 is released | |||
| chain-upgrade-tag: main # TODO: update this to a real tag once v8 is released | |||
Description
closes: #4216
This PR adds a helper fn which asserts the human readable denom is present
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.