Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revision height used for trusted validator set queries #4484

Closed
3 tasks
colin-axner opened this issue Aug 28, 2023 · 2 comments · Fixed by #5831
Closed
3 tasks

Fix revision height used for trusted validator set queries #4484

colin-axner opened this issue Aug 28, 2023 · 2 comments · Fixed by #5831
Assignees
Labels
testing Testing package and unit/integration tests type: bug Something isn't working as expected

Comments

@colin-axner
Copy link
Contributor

Summary

See comment thread starting here

The testing pkg should use the trusted height (without a + 1) to query for the trusted validator set through historical information. The API should be updated as well to clarify this interaction/expectations.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: bug Something isn't working as expected testing Testing package and unit/integration tests labels Aug 28, 2023
@colin-axner colin-axner self-assigned this Aug 28, 2023
@damiannolan
Copy link
Member

Can we close this issue now @colin-axner? Or did you want to keep it open for further follow ups?

@colin-axner
Copy link
Contributor Author

I was thinking of leaving this open until this API is updated or deleted, #4483 (comment) (addressing post v8 release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing package and unit/integration tests type: bug Something isn't working as expected
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

2 participants