nit(07-tendermint): remove unused authority argument. (#6890)

* nit(07-tendermint): remove unused authority argument. * docs: tweak integration section for registering tm light client module.
cosmos · Jul 19, 2024 · 6330deb · 6330deb
1 parent b9681af
commit 6330deb
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 15 deletions.
diff --git a/docs/docs/01-ibc/02-integration.md b/docs/docs/01-ibc/02-integration.md
@@ -247,13 +247,10 @@ import (
 // after sealing the IBC router
 
 clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
+storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
 
-tmLightClientModule := ibctm.NewLightClientModule(
-  appCodec, 
-  authtypes.NewModuleAddress(govtypes.ModuleName).String(),
-)
+tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)
 clientRouter.AddRoute(ibctm.ModuleName, &tmLightClientModule)
-
 app.ModuleManager = module.NewManager(
   // ...
   capability.NewAppModule(appCodec, *app.CapabilityKeeper, false),

diff --git a/modules/apps/callbacks/testing/simapp/app.go b/modules/apps/callbacks/testing/simapp/app.go
@@ -571,7 +571,7 @@ func NewSimApp(
 	clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
 	storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
 
-	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)
 	clientRouter.AddRoute(ibctm.ModuleName, &tmLightClientModule)
 
 	smLightClientModule := solomachine.NewLightClientModule(appCodec, storeProvider)

diff --git a/modules/core/02-client/types/router_test.go b/modules/core/02-client/types/router_test.go
@@ -6,9 +6,6 @@ import (
 
 	"github.com/stretchr/testify/require"
 
-	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
-	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
-
 	"github.com/cosmos/ibc-go/v9/modules/core/02-client/types"
 	"github.com/cosmos/ibc-go/v9/modules/core/exported"
 	ibctm "github.com/cosmos/ibc-go/v9/modules/light-clients/07-tendermint"
@@ -57,7 +54,7 @@ func (suite *TypesTestSuite) TestAddRoute() {
 			cdc := suite.chainA.App.AppCodec()
 
 			storeProvider := types.NewStoreProvider(suite.chainA.GetSimApp().GetKey(exported.StoreKey))
-			tmLightClientModule := ibctm.NewLightClientModule(cdc, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+			tmLightClientModule := ibctm.NewLightClientModule(cdc, storeProvider)
 			router = types.NewRouter()
 
 			tc.malleate()
@@ -114,7 +111,7 @@ func (suite *TypesTestSuite) TestHasGetRoute() {
 			cdc := suite.chainA.App.AppCodec()
 
 			storeProvider := types.NewStoreProvider(suite.chainA.GetSimApp().GetKey(exported.StoreKey))
-			tmLightClientModule := ibctm.NewLightClientModule(cdc, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+			tmLightClientModule := ibctm.NewLightClientModule(cdc, storeProvider)
 			router := types.NewRouter()
 			router.AddRoute(exported.Tendermint, &tmLightClientModule)
 

diff --git a/modules/light-clients/07-tendermint/light_client_module.go b/modules/light-clients/07-tendermint/light_client_module.go
@@ -22,7 +22,7 @@ type LightClientModule struct {
 }
 
 // NewLightClientModule creates and returns a new 07-tendermint LightClientModule.
-func NewLightClientModule(cdc codec.BinaryCodec, storeProvider clienttypes.StoreProvider, authority string) LightClientModule {
+func NewLightClientModule(cdc codec.BinaryCodec, storeProvider clienttypes.StoreProvider) LightClientModule {
 	return LightClientModule{
 		cdc:           cdc,
 		storeProvider: storeProvider,

diff --git a/modules/light-clients/08-wasm/testing/simapp/app.go b/modules/light-clients/08-wasm/testing/simapp/app.go
@@ -596,7 +596,7 @@ func NewSimApp(
 	clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
 	storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
 
-	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)
 	clientRouter.AddRoute(ibctm.ModuleName, &tmLightClientModule)
 
 	smLightClientModule := solomachine.NewLightClientModule(appCodec, storeProvider)

diff --git a/simapp/app.go b/simapp/app.go
@@ -554,7 +554,7 @@ func NewSimApp(
 	clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
 	storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
 
-	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)
 	clientRouter.AddRoute(ibctm.ModuleName, &tmLightClientModule)
 
 	smLightClientModule := solomachine.NewLightClientModule(appCodec, storeProvider)

diff --git a/testing/simapp/app.go b/testing/simapp/app.go
@@ -517,7 +517,7 @@ func NewSimApp(
 	clientRouter := app.IBCKeeper.ClientKeeper.GetRouter()
 	storeProvider := app.IBCKeeper.ClientKeeper.GetStoreProvider()
 
-	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider, authtypes.NewModuleAddress(govtypes.ModuleName).String())
+	tmLightClientModule := ibctm.NewLightClientModule(appCodec, storeProvider)
 	clientRouter.AddRoute(ibctm.ModuleName, &tmLightClientModule)
 
 	smLightClientModule := solomachine.NewLightClientModule(appCodec, storeProvider)