Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: introduce the consumer-modification handler #3178

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

insumity
Copy link
Contributor

Description

Introduces the ConsumerModificationProposal in gaia from ICS (see cosmos/interchain-security#1932 and cosmos/interchain-security#1949).

Testing
After this change we have:

gaiad tx gov submit-legacy-proposal
Error: failed to parse proposal: proposal type is required
Usage:
  gaiad tx gov submit-legacy-proposal [flags]
  gaiad tx gov submit-legacy-proposal [command]

Available Commands:
  cancel-software-upgrade Cancel the current software upgrade proposal
  change-reward-denoms    Submit a change reward denoms proposal
  consumer-addition       Submit a consumer addition proposal
  consumer-modification   Submit a consumer modification proposal
  consumer-removal        Submit a consumer chain removal proposal
  ...

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke mpoke merged commit 714e116 into main Jun 28, 2024
20 checks passed
@mpoke mpoke deleted the insumity/add-modification-proposal branch June 28, 2024 07:07
mergify bot pushed a commit that referenced this pull request Jun 28, 2024
(cherry picked from commit 714e116)
MSalopek pushed a commit that referenced this pull request Jun 28, 2024
(cherry picked from commit 714e116)

Co-authored-by: insumity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants