Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: statesync script for rs testnet #2745

Closed
wants to merge 4 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 21, 2023

Description

This PR adds a statesync script for the replicated security testnet.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@mpoke
Copy link
Contributor

mpoke commented Sep 22, 2023

@faddat Could you please provide more context on the need for testnet scripts in cosmos/gaia? There are already similar scripts in cosmos/testnets, i.e.,
https://github.com/cosmos/testnets/blob/master/replicated-security/provider/join-rs-provider.sh
https://github.com/cosmos/testnets/blob/master/replicated-security/provider/join-rs-provider-cv.sh

@faddat
Copy link
Contributor Author

faddat commented Sep 25, 2023

This one does not require using Ubuntu, and is in the gaia repository for easier testing.

@mpoke
Copy link
Contributor

mpoke commented Sep 27, 2023

and is in the gaia repository for easier testing

By adding it to the Gaia repo it means that the repo will contain more artifacts that need to be maintain. As it's testnet related, the best place for it is in cosmos/testnets

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 13, 2023
@github-actions github-actions bot closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants