Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move packages to internal #48

Closed
wants to merge 1 commit into from
Closed

chore: move packages to internal #48

wants to merge 1 commit into from

Conversation

technicallyty
Copy link
Contributor

closes: #37

  • moves code we dont want exported to internal
  • removes dead code (unused vtproto code)

@technicallyty technicallyty changed the title chore!: move packages to internal chore: move packages to internal Dec 9, 2021
@fdymylja
Copy link
Contributor

I wish we could put this on halt for now, I have two branches which are WIP for protomethods.Merge and custom types that would get into a conflict mess if we merged this right now.

aaronc
aaronc previously requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOLD until @fdymylja finishes his other PRs

@aaronc aaronc added the blocked label Apr 12, 2022
@julienrbrt julienrbrt dismissed aaronc’s stale review August 30, 2022 12:39

reason why blocked resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc aaronc left review comments

@fdymylja fdymylja Awaiting requested review from fdymylja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move everything that shouldn't be exported to internal packages
5 participants
@technicallyty @fdymylja @aaronc @tac0turtle @julienrbrt