Add default chain cosmoshub #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
webmaster128
reviewed
Jan 3, 2024
context/ChainsContext/index.tsx
Outdated
| @@ -61,7 +66,13 @@ export const ChainsProvider = ({ children }: ChainsProviderProps) => { | |||
| setChainsError(dispatch, chainItemsError); | |||
|
|
|||
| const loadedChain = getChain(chainItems); | |||
| setChain(dispatch, loadedChain); | |||
| const recentChains = getRecentChainNamesFromStorage(); | |||
There was a problem hiding this comment.
Why do we load recent chains? Is this used if non-empty? The setChain(dispatch, loadedChain); case does not seem to use recent chains
There was a problem hiding this comment.
Yes, that extra check is not needed. If getChain() returns empty chain it's because there are no recent chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184.
If the user goes to the root page without any chainname (
https://cosmos-multisig-ui-kohl.vercel.appinstead ofhttps://cosmos-multisig-ui-kohl.vercel.app/<chain-name>), it will be redirected tohttps://cosmos-multisig-ui-kohl.vercel.app/cosmoshubinstead of staying in an infinite loading screen.