New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate with e2e test #135

Merged

tak1827 merged 24 commits into dev from feature/add-e2e-test

Apr 21, 2022

Contributor

tak1827 commented Apr 12, 2022 •

edited

Loading

Checklist

succeed all test caes in e2e
succeed e2e test on workflow

Affected core subsystem(s)

nothing
- e2e test is independent

Description of change

adding e2e test related commands
- build node docker
- build relayer docker
- run e2e tests
adding e2e tests under the tests directory
- all most all code unchanged from original gaia
- only account address prefix(game) setting up code are added
  - left as comment

Related issues

research about e2e test feature #133

tak1827 added 2 commits

April 10, 2022 21:35


          integrate e2e tests

cdf122e


          rename gaia to nibiru

54b0dbb

tak1827 commented

View reviewed changes

Makefile

+              # build a node container
+              .PHONY: docker-build-debug
+              docker-build-debug:

Contributor Author

tak1827 Apr 12, 2022

building the docker for running nibiru node

Makefile

+              # build a relayer container
+              .PHONY: docker-build-hermes
+              docker-build-hermes:

Contributor Author

tak1827 Apr 12, 2022

building the docker for running relayer

Makefile

+              	@cd tests/e2e/docker; docker build -t cosmos/hermes-e2e:latest -f hermes.Dockerfile .
+              .PHONY: test-e2e
+              test-e2e:

Contributor Author

tak1827 Apr 12, 2022

executing all test cases in e2e

tests/e2e/chain.go

+              	cdc = encodingConfig.Marshaler
+              	config := sdk.GetConfig()
+              	nibiru.SetBech32AddressPrefixes(config)

Contributor Author

tak1827 Apr 12, 2022

setting game as address prefix

tests/e2e/chain.go Outdated

+              	return nil
+              }
+              // func (c *chain) createAndInitValidatorsWithMnemonics(count int, mnemonics []string) error {

Contributor Author

tak1827 Apr 12, 2022

comment out because of avoiding liner not using error

tests/e2e/e2e_util_test.go Outdated

+              	s.T().Log("successfully sent IBC tokens")
+              }
+              // func queryNibiruTx(endpoint, txHash string) error {

Contributor Author

tak1827 Apr 12, 2022

comment out because of avoiding liner not using error

tests/e2e/e2e_util_test.go Outdated

+              	return balancesResp.Balances, nil
+              }
+              // func queryNibiruDenomBalance(endpoint, addr, denom string) (sdk.Coin, error) {

Contributor Author

tak1827 Apr 12, 2022

comment out because of avoiding liner not using error

tests/e2e/keys.go Outdated

+              	return mnemonic, nil
+              }
+              // func createMemoryKey() (mnemonic string, info *keyring.Info, err error) {

Contributor Author

tak1827 Apr 12, 2022

comment out because of avoiding liner not using error

tests/e2e/keys.go Outdated

+              // 	return mnemonic, account, nil
+              // }
+              // func createMemoryKeyFromMnemonic(mnemonic string) (*keyring.Info, error) {

Contributor Author

tak1827 Apr 12, 2022

comment out because of avoiding liner not using error

tests/e2e/scripts/hermes_bootstrap.sh

+              grpc_addr = 'http://$NIBIRU_A_E2E_VAL_HOST:9090'
+              websocket_addr = 'ws://$NIBIRU_A_E2E_VAL_HOST:26657/websocket'
+              rpc_timeout = '10s'
+              account_prefix = 'game'

Contributor Author

tak1827 Apr 12, 2022

set game as address prefix

tak1827 self-assigned this

tak1827 added 16 commits

April 12, 2022 13:04


          upgrade linter version

c4631c9


          try golangci-lint v1.44.0

4496cd9


          try actions/[email protected]

72384f6


          try remove permission

916bd85


          try increase timeout

ef20c80


          try adding uses: actions/setup-go@v2

8e7c007


          try upgrade go version

f5bd57b

try

90065ef

try

try

9f2ada8

try

163586b

13599c5

try

2f96e36

4b55037


          upgrade linter version

b5a6ded


          remove unnecessary setting of linter

5551a35

tak1827 commented

View reviewed changes

.github/workflows/lint.yml

                     - name: golangci-lint
-                      uses: golangci/golangci-lint-action@v2
+                      uses: golangci/golangci-lint-action@v3

Contributor Author

tak1827 Apr 12, 2022

upgrade linter version to avoid the folloing error

failed to load package goarch

.github/workflows/lint.yml Outdated

@@ @@ -15,8 +15,11 @@ jobs: @@
                   runs-on: ubuntu-latest
                   steps:
                     - uses: actions/checkout@v2
+                    - uses: actions/[email protected]

Contributor Author

tak1827 Apr 12, 2022

this setting is required from linter@v3
https://github.com/golangci/golangci-lint-action#compatibility

.golangci.yml

		@@ -0,0 +1,4 @@
		run:

Contributor Author

tak1827 Apr 12, 2022

tests/e2e is not the target of linter
https://github.com/cosmos/gaia/blob/v7.0.0/.golangci.yml#L1

tak1827 added 2 commits

April 12, 2022 18:35


          expressly specify the version of linter version

933d82d


          add test.yml to workflow

7722cf2

tak1827 commented

View reviewed changes

.github/workflows/test.yml

		@@ -0,0 +1,33 @@
		name: Test

Contributor Author

tak1827 Apr 13, 2022

now e2e is ready on the github workflow

tak1827 requested a review from EG-easy

April 13, 2022 11:35

tak1827 added 2 commits

April 14, 2022 11:27


          Merge branch 'dev' into feature/add-e2e-test

9334e81

# Conflicts:
#	.github/workflows/lint.yml
#	go.mod
#	go.sum


          add router module

1f4ec48

tak1827 commented

View reviewed changes

Makefile

               		  -X github.com/cosmos/cosmos-sdk/version.Commit=$(COMMIT) \
               		  -X "github.com/cosmos/cosmos-sdk/version.BuildTags=$(build_tags_comma_sep)"
+              ifeq ($(LINK_STATICALLY),true)

Contributor Author

tak1827 Apr 18, 2022

add LINK_STATICALLY for wasmd
Ref: https://github.com/CosmWasm/wasmd/blob/master/Makefile#L68

app/app.go Outdated

@@ @@ -101,6 +101,9 @@ import ( @@
               	ibckeeper "github.com/cosmos/ibc-go/v2/modules/core/keeper"
               	nibiruappparams "github.com/cosmos-gaminghub/nibiru/app/params"
+              	"github.com/strangelove-ventures/packet-forward-middleware/router"

Contributor Author

tak1827 Apr 18, 2022

adding router module for ibc communication
Without this module, e2e test fail

2022-04-18T02:16:39.699871Z ERROR ThreadId(07) send_tx{id=chain-jN14rx}:estimate_gas: failed to simulate tx. propagating error to caller: gRPC call failed with status: status: Unknown, message: "failed to execute message; message index: 0: route not found to module: transfer: route not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "x-cosmos-block-height": "24"} }


          remove router middleware

63d2e67

EG-easy reviewed

View reviewed changes

Contributor

EG-easy left a comment

We can remove unused functions.

tests/e2e/chain.go Outdated Show resolved Hide resolved


          remove the comment outs of unusing code

c014c03

tak1827 requested a review from EG-easy

April 21, 2022 08:50

EG-easy approved these changes

View reviewed changes

Contributor

EG-easy left a comment

🍵

tak1827 merged commit 49ec354 into dev

tak1827 deleted the feature/add-e2e-test branch

April 21, 2022 09:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet