Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide fmt.Stringer for EventType #13

Merged
merged 1 commit into from
Mar 3, 2021
Merged

chore: provide fmt.Stringer for EventType #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ const (
Destroyed
)

func (eventType EventType) String() string {
return [...]string{"Created", "Updated", "Destroyed"}[eventType]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use stringer tool? https://pkg.go.dev/golang.org/x/tools/cmd/stringer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never used, that, good point, if this requires changing build steps, might be too much work for this PR, but certainly something for the future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siderolabs/kres#53

}

// Event is emitted when resource changes.
type Event struct {
Type EventType
Expand Down