Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken provisioning #1800

Open
wants to merge 2 commits into
base: 2023.9.x
Choose a base branch
from

Conversation

skamensky
Copy link
Contributor

The following changes are implemented

TODO: Summary

Changes in the user interface:

TODO: Add screenshots, recordings or remove this section

Checklist when submitting a final (!draft) PR

  • Commits are tidied up, squashed if needed and follow guidelines in CONTRIBUTING.md
  • Code builds
  • All existing tests pass
  • All new critical code is covered by tests
  • PR is linked to the relevant issue(s)
  • Rebased with the target branch

Signed-off-by: skamensky <[email protected]>
Signed-off-by: skamensky <[email protected]>
@tjerman
Copy link
Member

tjerman commented Jun 6, 2024

Could you please explain when exactly this failed and why this fixes it? I'd imagine we'd find it long ago if it was a boot level issue 😅

Copy link

github-actions bot commented Aug 6, 2024

Stale pull request message

@Fajfa
Copy link
Member

Fajfa commented Sep 30, 2024

@skamensky Am cleaning up PR's. Is this still relevant?

@skamensky
Copy link
Contributor Author

I'm not sure. I'm using a frozen version of corteza at this point.

Feel free to close from my POV.

There was an actual bug and this is an actual fix. Maybe note that somewhere in case you get a provisioning error in the future to save you the bug hunt.

@Fajfa
Copy link
Member

Fajfa commented Oct 1, 2024

Okay thanks, will leave it open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants