Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bodiless.c: Don't write a temporary file in the source directory. #452

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

mattmccutchen-cci
Copy link
Member

Hopefully fixes #378 for real this time.

I tested via a temporary chmod u-w clang/test/3C on my laptop that no other tests try to create files in the directory. I assume that result will hold true on Windows too.

Copy link
Member

@kyleheadley kyleheadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there was just one file left over? How was it missed and how do you know there isn't another one? But feel free to merge this.

@mattmccutchen-cci
Copy link
Member Author

How was it missed

It was the only one that didn't use -output-postfix. I didn't realize there were any tests that wrote to clang/test/3C by other means.

how do you know there isn't another one?

I ran the tests with chmod u-w clang/test/3C. Better ideas?

@mattmccutchen-cci mattmccutchen-cci merged commit 9e6f2d8 into main Feb 25, 2021
@mattmccutchen-cci mattmccutchen-cci deleted the bodiless-temp-file branch February 25, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3C output is not cleaned up when a test fails.
2 participants