WIP: Need to make recurring rides work as a feature; Fixed Schedule so that rides from other days show up.

[namanhboi]

Summary

Currently, recurring rides doesn't work at all. It doesn't show up in the scheduled/unscheduled rides table of other days nor does it show up in the big Schedule in the home page.
screen-capture (3).webm

This is because the useRides() function that both the rides table and schedule uses from RidesContext.tsx only pulls from the backend the rides from the current day. Since the recurring rides doesn't exist in the backend, they won't show up in the tables or the schedule.

I plan to add the recurring rides feature by updating scheduledRides and unscheduledRides of RidesContext to have both the normal and recurring rides, which haven't been added to the backend yet. This ensures that these recurring rides show up in the ride tables and schedules. When we need to delete or edit these recurring rides, that's when we communiate with the database.

Additionaly, I also found 2 bugs which I both fixed:

• The schedule doesn't show rides from days other than the original day.
  
  Here, the ride at the bottom doesn't show up on the schedule
• Can't edit recurring rides.
  
  __I clicked on the edit button of the ride on the bottom, which is a recurring ride, and nothing shows up.

However, I found another bug in the backend that diasbled access to the carriage website which persists on the master branch.


The origin is here

This might have been caused by me doing some work in RidesContext.

This pull request is the first step towards making the recurring rides work.

• added recurring rides to scheduledRides and unscheduledRides of RidesContext . These rides are not in the back end.
• need to do something about deleting a recurring ride (delete all recurring rides or just that one).
• need to add a new ride to the backend when you edit a recurring ride
• fixed the 2 bugs mentioned above

Test Plan

I plan to add recurring rides and manually check if they show up in other days.

Breaking Changes

This bug:

This might have been caused by me doing some work in RidesContext. The master branch now doesn't work?

[dti-github-bot]

[diff-counting] Significant lines: 697.

[raissaji]

Hi Nam, great job noticing the bugs! When I pulled your branch, I am coming across an error 500—I took a look at the server log and it appears that the problem lies in your get request const ridesDataToday: Ride[] = await axios in RidesContext. I left a more specific comment in the file that could help you with debugging.

Because of the AxioError, I couldn't add a ride to test how you squashed the bugs.

[namanhboi]

Ride type:

export type RideType = {
 id: string;
 type: Type;
 status: Status;
 late: boolean;
 startLocation: RideLocation;
 endLocation: RideLocation;
 startTime: string;
 endTime: string;
 rider: RiderType;
 driver?: DriverType;
 recurring: boolean;
 recurringDays?: number[];
 endDate?: string;
 deleted?: string[];
 edits?: string[];
 sourceRide? : RideType;
 immediateParentRide?: RideType;
 children? : RideType;
 sourceRideId? : string;
 immediateParentRideId? : string;
 childrenId? : string;
};

Recurring rides design:

• sourceRide: the root of the recurring ride tree.
• immediateParentRide: the immediate parent ride of the current recurring ride.
• childrenRide: the singular children recurring ride of the current ride.

useRides()

• all recurring rides returned from useRides() are ride objects: all rides object with recurring = true has immediateParentId and sourceRideId that is not null (they all link to some ride in the db).

Add and Edit design:

3 options to edit:

1. edit all :

• Go to the source ride, delete all children ride by recursing down the children’s id.
• apply edit to original
• refreshRides

2. edit from now:

• Note that we need to lock the date in the edit modal since its from now.![][image1]
• trim the end date of the immediate parent to before today
• go down the tree of all children rides and delete all of them
• create a new ride with the edited data which has the immediateParentRide and immediateParentRideId be from the immediate parent
• Add that ride to the immediate parent’s childrenRide and childrenRideId.
• refreshRides

3. edit a single ride:

• Note: should also lock the date for simplicity.
• trim end date of immediate parent to before this day.
• add a new ride with the edited data on that date with immediateParent and immediateParentId being from the immediate parent.
• The children of the immediate parent is this ride.
• create a new recurring ride on the date + 1 with data similar to parent if the parent’s endTime allow for it. Add the id of the parent ride as the id of the newly created ride.
• refreshRides

3 options to delete:

1. delete all:

• go to source ride, delete itself and all children rides
• refreshRides

2. delete from now until end date of current ride

• go to parent ride, trim end date to before today, delete all children rides
• refreshRides

3. delete this single ride:

• trim end date of immediate parent to before this day.
• delete all children rides of the immediate parent.
• create a new ride on the date + 1 with data similar to parent if the parent’s endTime allow for it. Add the id of the parent ride as the id of this ride’s parentId.
• refreshRides

[namanhboi]

This ride causes error on the server side because the rider is a name instead of an id to a driver object in Dynamo.

Gotta be mindful of this when creating recurring rides.