Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location Modal #505

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Location Modal #505

wants to merge 14 commits into from

Conversation

raissaji
Copy link
Contributor

@raissaji raissaji commented Mar 24, 2024 •
edited
Loading

Summary

This pull request is for implementing the redesign of the Location Modal. These are the following changes:

  • Redesigned modal, input boxes, titles, and buttons according to Figma designs
  • Highlight on close button only appears on click
  • Edit location now saves the changes (bug fix)
  • Tag selector is by default "Select a tag" instead of "East"

Test Plan

Screen.Recording.2024-11-16.at.1.12.27.PM.mov
  • Error messages appear for all inputs when they're blank
  • Error message for address input turns to "Invalid address" if it doesn't exist
  • New location properly saves
  • Location edits save

Breaking Changes

None

@raissaji raissaji requested a review from a team as a code owner March 24, 2024 17:34
@dti-github-bot
Copy link
Member

dti-github-bot commented Mar 24, 2024 •
edited
Loading

[diff-counting] Significant lines: 155.

@raissaji
Implement New Location Modal Designs and Functionality
86f4dbf 
- Formatted input boxes and titles according to Figma designs
- Add appropriate error messages with accurate functionality
- Add Clear All and Back buttons
@raissaji raissaji changed the title rj353/location modal Location Modal Apr 16, 2024
@raissaji raissaji assigned raissaji and unassigned raissaji Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selenaliu1 selenaliu1 selenaliu1 left review comments

@namanhboi namanhboi namanhboi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raissaji @dti-github-bot @namanhboi @selenaliu1