Fix nvm node upgrades | Update regex node.js version matching #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js has now added support for Windows ARM64, which broke the regex version match in nvm.go, as it was only looking for msi files that had an "-x" in it (for x86 and x64). Went ahead and updated the regex to match x86, x64, and amd64 arm and now it can compare the versions properly and the `index of out range error` won't show up. (It was happening because it would try to compare `[19,9,0] with [19,9,0-arm,msi]`
This was referenced Apr 11, 2023
|
Thank you for this. I won't be accepting it though, because I already made these changes locally.... they just haven't been pushed yet :-) |
When can we expect a new version? with a fix? |
EDIT: NVM the fix is in.I was looking for a pull request but it seems it was just committed to master directly. @coreybutler 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues people are having with upgrading node. (e.g fixes: (#955) (#942) )
Node.js has added support for Windows ARM64 MSI files, which broke the regex version matching in nvm.go. It was only looking for msi files that had an "-x" in it (due to x86 and x64) and would use that -x as a reference point to retrieve the version number.
Went ahead and updated the regex so it can match x86, x64, and arm64 MSI's and now it can compare the versions properly.
This resolves the
panic: runtime error: index out of range [3] with length 3error. (which was happening because it would try to compare[19,9,0]with[19,9,0-arm,msi]