Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master][CDRP-58] COBAR data processing issue #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polonevitch
Copy link

As from the name of the function, native_pointer returns an actual address in memory by given offset through adding it to the mapped file starting position. I see from the code, it is covered by checks for null of the function return, but ignores a possibility of the null offset. This approach seems to be kind of useless, since the original function always returns not null result because of the not null mapped file address.
The PR does an additional check before summing values and gives a try for external check to prevent crash in case of a empty function parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant