Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom colors in interactions #420

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

amiklosi
Copy link
Contributor

@amiklosi amiklosi commented Aug 4, 2015

No description provided.

override def singleResource[A >: EssentialAction](context: String, componentType: String, suffix: String): A = Action { implicit request =>
val (body, ct) = generate(context, allComponents.find(_.matchesType(componentType)).toSeq, suffix)
override def singleResource[A >: EssentialAction](context: String, componentType: String, suffix: String, resourceToken: String = "default"): A = Action { implicit request =>
val paramsJson = resourceToken match {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication? line 65?

override def singleResource[A >: EssentialAction](context: String, componentType: String, suffix: String): A = Action { implicit request =>
val (body, ct) = generate(context, allComponents.find(_.matchesType(componentType)).toSeq, suffix)
val resourceToken = request.queryString.get("resourceToken")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication w/ line 69?

@@ -19,6 +20,7 @@ describe('editor config', function() {

beforeEach(module(function($provide) {
designerService = new MockDesignerService();
$provide.value('MathJaxService', MathJaxService);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to add this - EditorConfig doesn't rely on MathjaxService

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure but i was getting an error without it

…respring/corespring-container into feature/custom-colors-in-interactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants