Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: update dependencies #1175

Merged
merged 1 commit into from
Apr 28, 2024
Merged

cargo: update dependencies #1175

merged 1 commit into from
Apr 28, 2024

Conversation

HuijingHei
Copy link
Member

No description provided.

@HuijingHei
Copy link
Member Author

CI failed

  • error: package clap_builder v4.5.2 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.71.0
  • error: package clap_derive v4.5.4 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.71.0

Should I update rust-version = "1.71.0" to rust-version = "1.74.0" in Cargo.toml?

@jlebon
Copy link
Member

jlebon commented Apr 17, 2024

I think we can bump to 1.75.0. See coreos/coreos-installer#1453.

@HuijingHei HuijingHei force-pushed the pre-release-0.0.28 branch 4 times, most recently from 106e8ff to a49caaf Compare April 18, 2024 14:43
@HuijingHei
Copy link
Member Author

The failed log seems wired, run successfully locally, will look more about it.

@jlebon
Copy link
Member

jlebon commented Apr 18, 2024

Possibly related to the zbus bump from 3.6 to 3.15. Odd that you can't reproduce it locally though. Are you sure that's with the same Cargo.lock?

@HuijingHei
Copy link
Member Author

Possibly related to the zbus bump from 3.6 to 3.15. Odd that you can't reproduce it locally though. Are you sure that's with the same Cargo.lock?

I rebuild with override/rootfs, can reproduce the failed issue locally, thanks!

# busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefreshTime
Call failed: The name is not activatable

@HuijingHei
Copy link
Member Author

Thanks @jlebon for the pointer, see #1119 (comment) and #966, will skip zbus update

qemu0 kola-runext-test-experimental.sh[2136]: # Call failed: The name is not activatable

qemu0 kola-runext-test-experimental.sh[2129]: + fatal 'File '\''err.txt'\'' doesn'\''t match regexp '\''Access denied'\'''

qemu0 kola-runext-test-experimental.sh[2129]: + echo error: File ''\''err.txt'\''' 'doesn'\''t' match regexp ''\''Access' 'denied'\'''

qemu0 kola-runext-test-experimental.sh[2129]: error: File 'err.txt' doesn't match regexp 'Access denied'

qemu0 kola-runext-test-experimental.sh[2129]: + exit 1

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though we should try to get to the bottom of that zbus issue at some point. Would be nice if we could stop bundling in Fedora, and I think this will likely be an issue.

@HuijingHei
Copy link
Member Author

LGTM. Though we should try to get to the bottom of that zbus issue at some point. Would be nice if we could stop bundling in Fedora, and I this will likely be an issue.

Yes, will create an issue to track it.

Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HuijingHei HuijingHei merged commit 1b243c3 into main Apr 28, 2024
8 checks passed
@HuijingHei HuijingHei deleted the pre-release-0.0.28 branch April 28, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants