backdoor: allow avoiding iopl permission errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Oct 6, 2020
This introduces additional methods for the backdoor-opening logic, in order to allow consuming applications to keep going when changing I/O access level is not alloewd (see kernel_lockdown(7) on Linux). In most cases the library may work without higher I/O level, and actual failures can be handled via normal error-handling on RPC methods.
lucab
changed the title
|
I've repurposed the existing methods and added a new pair of I was actually unsure whether to do the opposite, i.e. keeping the existing methods with the |
cgwalters
approved these changes
Oct 7, 2020
|
@cgwalters thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces additional methods for the backdoor-opening logic,
in order to allow consuming applications to keep going when changing
I/O access level is not allowed (see kernel_lockdown(7) on Linux).
In most cases the library may work without higher I/O level,
and actual failures can be handled via normal error-handling on RPC
methods.
Ref: https://github.com/lucab/vmw_backdoor-rs/issues/6