Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump actions/upload-artifact from 3 to 4" #268

Conversation

travier
Copy link
Member

@travier travier commented Nov 22, 2024

Reverts #252

This failed: https://github.com/coreos/repo-templates/actions/runs/11958253598

Run actions/download-artifact@v3
  with:
    name: rendered
  env:
    REPO_NAME: 11bot
/usr/bin/docker exec  0ff5a3[2](https://github.com/coreos/repo-templates/actions/runs/11958253598/job/33337388570#step:7:2)5d9b1750c4b8dbc8167d8d267[3](https://github.com/coreos/repo-templates/actions/runs/11958253598/job/33337388570#step:7:3)a05f5b79e6dc55df8d5c652[4](https://github.com/coreos/repo-templates/actions/runs/11958253598/job/33337388570#step:7:4)756328c sh -c "cat /etc/*release | grep ^ID"
Starting download for rendered
Error: Unable to find any artifacts for the associated workflow

Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hmm, the error looks wired

@HuijingHei
Copy link
Member

HuijingHei commented Nov 22, 2024

A little confused, the error is about actions/download-artifact@v3, but what we are using is v4(without this patch), am I missing something?

@travier
Copy link
Member Author

travier commented Nov 22, 2024

Hum, we might need to update both the download and upload one at the same time to the same version.

@travier
Copy link
Member Author

travier commented Nov 22, 2024

Let's try it: #253

@travier travier marked this pull request as draft November 22, 2024 13:12
@travier
Copy link
Member Author

travier commented Nov 25, 2024

Looks like #253 did it, as https://github.com/coreos/repo-templates/actions/runs/11973256772 failed on #267 which I think we should revert for now: #269

@travier travier closed this Nov 25, 2024
@travier travier deleted the revert-252-dependabot/github_actions/actions/upload-artifact-4 branch November 25, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants