-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignition spec bump #562
Ignition spec bump #562
Conversation
6e2436b
to
dc751e7
Compare
Hum, it looks like you're trying to stabilize a lot of variants in this PR at the same time. |
I had copied the entire template in the issue but we don't need to do it all. We only need to bump the experimental versions. |
So, I took another look at this and what I would do is to only bump ignition to 3.6-exp first in all the experimental config variants. Then in #559, we would stabilise the base, fcos and 4.18 config variants on 3.5.0 and keep all of the other variants on the new exp base & fcos ones. |
b626e3c
to
e37ee9c
Compare
spoke with @travier ; dialing back changes to go into independent prs, #550 (comment) . You can see that this pr is simply an import of the latest ignition with its now stabilized 3.5, which resulted in some new docs, see second commit. |
bc58172
to
72550e5
Compare
I considered splitting the vendor part from the changes in the first commit but that would have made it non-atomic / harder to bissect while making it easier to distinct which changes were manual vs the vendor code. But overall it's the same result so let's go with that as it's bissectable. |
Hum, maybe we should move the specs that we are not going to stabilize directly to 3.6.0-exp in this one. |
Or we make a followup PR, that works as well. |
Thats fair, I was thinking I would do that when adding the new base, which I assumed I would do with other sterilizations (fcos) |
#558