-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add labels to PR #18
feat: Add labels to PR #18
Conversation
@brett-anderson Wait how did you manage to make it work? From the CI/CD run, we can see that no |
I used it inline with the workflow that I'm tracing, perhaps that is how it is working? This is an example of what the workflow looks like: name: CI
on:
pull_request:
types:
- opened
- synchronize
- reopened
- labeled
- unlabeled
jobs:
ci:
uses: wrapbook/app-ci/.github/workflows/ci.yml@main
secrets: inherit
otel-export-trace:
name: OpenTelemetry Export Trace
if: always()
runs-on: ubuntu-latest
needs: ci
steps:
- name: Export Workflow Trace
uses: wrapbook/otel-cicd-action@add-ignored-steps
with:
otlpEndpoint: grpc://api.honeycomb.io:443/
otlpHeaders: x-honeycomb-team=${{ secrets.HONEYCOMB_GHA_CI_APIKEY }}
otelServiceName: otel-export-trace
githubToken: ${{ secrets.GITHUB_TOKEN }} |
@corentinmusard I've now moved this to a triggered workflow, new workflow looks like this:
I am still having the labels show up: Maybe because this PR is created outside of the repo? I could try re-creating it within the repo to see if that adds the pull request to the context. |
42a28b2
to
fb9ce3e
Compare
This adds the labels from a PR to the trace span.
Here is an example from testing: