Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): change icon to css #1517

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(collapse): change icon to css #1517

wants to merge 7 commits into from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 23, 2024

Опишите проблему

Парные иконки заменены на одну иконку и css-rotate

Внешний вид

Без изменений
https://core-ds.github.io/core-components/feat_ds_7758_40_1a7856f854b38680118620a9bdb86861df754694/?path=/docs/collapse--docs

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 82d7be0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@alfalab/core-components-collapse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
collapse/index.js 16.4 (-0.50 KB💚)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 23, 2024 22:46
@SiebenSieben
Copy link
Contributor

@Oladii

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12706978678

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 82.311%

Totals Coverage Status
Change from base Build 12687195203: -0.004%
Covered Lines: 10743
Relevant Lines: 11909

💛 - Coveralls

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx
Copy link
Contributor Author

denisx commented Jan 10, 2025

@Oladii скрины прошли, с тебя нужен чек?

@denisx
Copy link
Contributor Author

denisx commented Jan 14, 2025

@SiebenSieben plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants