Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lambda-manager code to handle ThrottlingException [CDS-1331] #153

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Jul 1, 2024

Description

  • Add config to boto3 in order for the lambda to not fail in case of ThrottlingException error from AWS.
  • Update the python code so it will not thought errors in case the lambda cant add subscription to log group.
  • In case the user will update the cloudformation after its creation then the SCAN_OLD_LOGGROUPS will be set to true again, added another function and condition to handle it -> update_scan_all_log_groups_status
Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the changed module in the template index.js and package.json files.
  • I have updated the relevant component changelog(s)
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from juan-coralogix July 1, 2024 07:49
Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyrenny guyrenny merged commit f5afcd4 into master Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants