Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate.sh #13

Closed
wants to merge 1 commit into from
Closed

Fix generate.sh #13

wants to merge 1 commit into from

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Mar 10, 2020

POSIX shells do not support brace expansion, so {,.} requires bash or so.

POSIX shells do not support brace expansion, so `{,.}` requires bash or so.
@erikmd
Copy link
Member Author

erikmd commented Mar 10, 2020

Hi @palmskog @Zimmi48

During the preparation of the README.md of the coqoban repo, I wanted to use your mustache-based generator; I had first proposed that PR to do a small improvement of the generate.sh script, then noticed that the shellcheck linter was still not happy with the current version of the script, so I cloned the repo, do a second commit and pushed... without noticing that I had pushed this commit directly in master, not in the fix-generate :-/

I'm sorry for that branch mistake… hopefully it did not cause too much harm.

@erikmd erikmd closed this Mar 10, 2020
@erikmd
Copy link
Member Author

erikmd commented Mar 10, 2020

So I propose to do a git revert of my commit and re-open another PR so that we can discuss that change?
sorry again :-/

@erikmd
Copy link
Member Author

erikmd commented Mar 10, 2020

Hi @palmskog, on second thought the commit I inadvertently pushed directly to master is very fine (except that I had replaced mustache with pystache, which won't work as is, due to the input format difference I mentioned here: #14 (comment) ), so maybe you could push yourself another commit directly to master that revert this program name to mustache?

@erikmd erikmd deleted the fix-generate branch March 10, 2020 18:09
@palmskog
Copy link
Member

@erikmd OK done

@Zimmi48
Copy link
Member

Zimmi48 commented Mar 12, 2020

I've changed /bin/bash into /usr/bin/env bash which is more portable (/bin/bash doesn't exist on NixOS for instance).

@erikmd
Copy link
Member Author

erikmd commented Mar 12, 2020

OK thanks @Zimmi48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants