-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Section headers #34
Open
benadamstyles
wants to merge
8
commits into
cooperka:master
Choose a base branch
from
benadamstyles:section-header-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Section headers #34
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f5d14ca
initial commit
benadamstyles d83fa3c
lint fixes
benadamstyles cba8549
improvements based on comments from @cooperka
benadamstyles 39e81fd
Code style tweaks
cooperka 073c262
handle Map of Lists, add tests
benadamstyles 6394033
pass whole `info` object to `renderItem()` and `renderSectionHeader()…
benadamstyles 53ac8fb
fix renderSectionHeader branch condition
benadamstyles 090b2d4
update sectionHeader test snapshots
benadamstyles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the problem stems from this line. In your example app, you’re (understandably!) assuming that
renderItem()
will be called with the wholeinfo
object (as it is if we are dealing with a flat list without section headers, 3 lines below this comment). Will push a fix asap!