Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cache and make sure we are not fetching invalid path #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions file-fire-cache-behavior.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/** * Using a Map to efficiently cache url that have already been fetched */
<script>
(function() {
var cache = new Map();

window.myBehaviors = window.myBehaviors || {};

/* @polymerBehavior myBehaviors.FileFireCache */
myBehaviors.FileFireCache = {
/*
* `_pathReady` returns true if the path is a valid path
*/
__pathReady: function(path) {
return path && path.split('/').slice(1).indexOf('') < 0;
},

setCache: function(path, url) {
cache.set(path, url);
},

getCache: function(path) {
return cache.get(path);
},

cleaCache: function() {
cache.clear();
}
};

})();
</script>
144 changes: 81 additions & 63 deletions file-fire-fetch.html
Original file line number Diff line number Diff line change
@@ -1,77 +1,95 @@
<link rel="import" href="../polymer/polymer.html">
<link rel="import" href="../polymerfire/firebase.html">

<link rel="import" href="file-fire-cache-behavior.html">
<dom-module id="file-fire-fetch">
<script>
/**
* An element that provides the url to a file based on the FireBase storage path
* Example:
* ```
* <firebase-app
* name="demo"
* api-key="API_KEY"
* auth-domain="AUTH_DOMAIN"
* database-url="DATABASE_URL"
* storage-bucket="convoofire.appspot.com">
* </firebase-app>
* <!-- A file-fire-fetch element allowing image upload to firebase storage -->
* <file-fire-fetch
* app-name="demo"
* path="/my/path/to/file.jpg"
* file-url="{{myFileURL}}"
* ></file-fire-fetch>
* ```
*
*
* @demo demo/file-fire-fetch.html
*/
Polymer({
is: 'file-fire-fetch',
properties: {
/**
* `appName` represents the name of the firebase-app that was instantiated
*/
appName: {
type: String,
},
/**
* `path` represents where the file should be saved, if the path doesnt exist it will be created
*/
path: {
type: String,
observer: "_updateFile"
},
/**
* `fileUrl` represents the file's direct url'
*/
fileUrl: {
type: String,
notify: true,
reflectToAttribute: true
},
fileExists: {
type: Boolean,
value: false,
notify: true
}
/**
* An element that provides the url to a file based on the FireBase storage path
* Example:
* ```
* <firebase-app
* name="demo"
* api-key="API_KEY"
* auth-domain="AUTH_DOMAIN"
* database-url="DATABASE_URL"
* storage-bucket="convoofire.appspot.com">
* </firebase-app>
* <!-- A file-fire-fetch element allowing image upload to firebase storage -->
* <file-fire-fetch
* app-name="demo"
* path="/my/path/to/file.jpg"
* file-url="{{myFileURL}}"
* ></file-fire-fetch>
* ```
*
*
* @demo demo/file-fire-fetch.html
*/
Polymer({
is: 'file-fire-fetch',

behaviors: [
myBehaviors.FileFireCache
],

properties: {
/**
* `appName` represents the name of the firebase-app that was instantiated
*/
appName: {
type: String,
},

/**
* `path` represents where the file should be saved, if the path doesnt exist it will be created
*/
path: {
type: String,
observer: "_updateFile"
},

/**
* `fileUrl` represents the file's direct url'
*/
fileUrl: {
type: String,
notify: true,
reflectToAttribute: true
},

fileExists: {
type: Boolean,
value: false,
notify: true
}
},

_updateFile: function(newVal){
if(newVal){
var storage = firebase.storage(firebase.app(this.appName));
var storageRef = storage.ref();
storageRef.child(this.path).getDownloadURL().then(function(url) {
this.fileUrl = url;
this.fileExists = true;
_updateFile: function(path) {
if (path && this.__pathReady(path)) {
var cached = this.getCache(path);
if(cached) {
this.fileUrl = cached;
this.fileExists = true;
return;
}
var storage = firebase.storage(firebase.app(this.appName));
var storageRef = storage.ref();
storageRef.child(path).getDownloadURL().then(function(url) {
this.fileUrl = url;
this.fileExists = true;
this.setCache(path, url);
}.bind(this))
.catch(function(error) {
this.fire("no-file", {message:"No file exists at this location", error: error});
this.fileExists = false;
// console.log(error);
this.fire("no-file", {
message: "No file exists at this location",
error: error
});
this.fileExists = false;
// console.log(error);
}.bind(this));
}
}

});
});
</script>
</dom-module>