Add custom walking traversal permissions via TransportNetworkConfig #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abyrd
reviewed
Oct 3, 2024
| public StreetLayer(TransportNetworkConfig config) { | ||
| this(); | ||
| if (config != null && config.traversalPermissionLabeler != null) { | ||
| // TODO cleaner mapping |
There was a problem hiding this comment.
This can be done with switch expressions, for example:
if (config != null) {
permissionLabeler = switch (config.traversalPermissionLabeler) {
case "sidewalk" -> new SidewalkTraversalPermissionLabeler();
case null -> new USTraversalPermissionLabeler();
default -> throw new IllegalArgumentException("Unknown traversal permission labeler: " + config.traversalPermissionLabeler);
};
} else {
permissionLabeler = new USTraversalPermissionLabeler();
}
trevorgerhardt
approved these changes
Oct 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users want the ability to configure different traversal permission labeling approaches (e.g., disallowing walking on any links that allow driving, under the assumption complete and separate sidewalk networks are available, see #643)
This PR should be considered together with #941. Together with those changes, this PR allows users to build networks using a new experimental
SidewalkTraversalPermissionLabelerwith stricter walking permissions that are likely to be appropriate as more complete sidewalk networks become available.Based on discussions in a work session a couple months ago, this PR removes the
buildNetworkFromBundleZipmethod that has been unsupported since 2016.This PR partly addresses #751 by passing
TransportNetworkConfigvalues inPointToPointRouterServeruse. The remaining piece of that r5r-related issue is allowing users to specify whether to save detailed GTFS shapes (which will be useful for us in publishing Taui sites, see #644)