Prevent runaway error reporting #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move filterStackTrace method into shared utility class
abyrd
force-pushed
the
job-error-limiting
branch
from
2efbc15 to
9df41b6
Compare
This was referenced Dec 20, 2023
Merged
ansoncfit
approved these changes
Dec 26, 2023
Comment on lines
+401
to
+405
| // Limit the number of errors recorded to one. | ||
| // Still using a Set<String> instead of just String since the set of errors is exposed in a UI-facing API. | ||
| if (job.errors.isEmpty()) { | ||
| job.errors.add(error); | ||
| } |
There was a problem hiding this comment.
This seems like a sensible safeguard -- in most cases, error messages coming in from workers will be identical. And if they vary slightly (e.g. including a different origin id), we probably don't want to record all messages separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses problems discussed in #919 and #887. It makes two small changes, each of which alone would prevent the runaway error reporting observed on 2023-12-18 (EST). In addition it reduces the volume of errors sent and recorded.