New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused pattern trips field #890

Merged

trevorgerhardt merged 1 commit into dev from remove-pattern-trips

Oct 16, 2023

Member

trevorgerhardt commented Oct 5, 2023 •

edited

Loading

This field is not used anywhere in R5 and will no longer be used in the UI. This corresponds to https://github.com/conveyal/ui/pull/1978.


          Remove unused pattern trips field.

0d966c0

trevorgerhardt marked this pull request as ready for review

October 5, 2023 08:01

trevorgerhardt enabled auto-merge (squash)

October 5, 2023 08:01

trevorgerhardt requested review from abyrd and ansoncfit

October 6, 2023 03:03

Member

abyrd commented Oct 16, 2023

Discussed in call:

R5 worker version of this class com.conveyal.r5.analyst.scenario.AdjustFrequency does not even have a corresponding field, so there should be no issue with worker version backward compatibility.
Deserializer handling objects coming out of Mongo has "fail on unknown properties" set to false, so we don't expect problems even if R5 encounters old database records containing this field.

abyrd approved these changes

View reviewed changes

trevorgerhardt merged commit 4321da8 into dev

3 checks passed

trevorgerhardt deleted the remove-pattern-trips branch

October 16, 2023 13:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet