Refactor the multi-origin result assemblers #860
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
January 30, 2023 17:15
Pull request was converted to draft
trevorgerhardt
force-pushed
the
refactor-multi-origin-assembler
branch
2 times, most recently
from
f53df35 to
be2c736
Compare
trevorgerhardt
force-pushed
the
refactor-multi-origin-assembler
branch
from
424181e to
ca1ba48
Compare
Refactor the multi-origin assembler and the individual result assembler classes to allow them to be created during the regional analysis creation process so that the Broker and MultiOriginAssembler can be simpler and depend on fewer components.
Was missing after the merge.
This way, each writer and the assembler do not need to be directly passed a Component.
Into the RegionalAnalysisController
trevorgerhardt
force-pushed
the
refactor-multi-origin-assembler
branch
from
0a6f9b1 to
f6c409e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the multi-origin assembler and the individual result assembler classes to allow them to be created during the regional analysis creation process. This allows the
BrokerandMultiOriginAssemblerclasses to be simpler and depend on fewer components themselves.