Skip to content

Commit

Permalink
Merge pull request #26 from conveyal/dev
Browse files Browse the repository at this point in the history
New release
  • Loading branch information
evansiroky authored Oct 25, 2019
2 parents 13a1345 + 5e9cb06 commit 03e3511
Show file tree
Hide file tree
Showing 5 changed files with 5,799 additions and 4,793 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ cache:
notifications:
email: false
node_js:
- '8'
- '10'
after_success:
- npm run semantic-release
branches:
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ after_success:
- semantic-release --prepare @conveyal/maven-semantic-release --publish @semantic-release/github,@conveyal/maven-semantic-release --verify-conditions @semantic-release/github,@conveyal/maven-semantic-release --verify-release @conveyal/maven-semantic-release --use-conveyal-workflow --dev-branch=dev --disable-snapshot-skip-ci --disable-final-skip-ci
```

If you use the conveyal workflow just the updated `pom.xml` will be part of the commit. To add more files to the commit (e.g. a CHANGELOG.md generated by a different plugin) you can specify those via the parameter `--additionalFilesToCommit`. This parameter accepts a list of filenames and will include them in the commit. Example:
```
after_success:
- semantic-release --prepare @conveyal/maven-semantic-release --publish @semantic-release/github,@conveyal/maven-semantic-release --verify-conditions @semantic-release/github,@conveyal/maven-semantic-release --verify-release @conveyal/maven-semantic-release --use-conveyal-workflow --dev-branch=dev --additionalFilesToCommit CHANGELOG.md,readme.txt
```

#### before_install

Be sure to include the import of your signing keys. If you followed everything correctly in step 4 you should have something like the following added to your .travis.yml file:
Expand Down Expand Up @@ -132,3 +138,5 @@ Create a Github token that will be used to make commits and create releases. Ad
## Which `mvn` will be used

This plugin uses the `mvn` command in your `PATH`. If you have [maven-wrapper script](https://github.com/takari/maven-wrapper) at the project root directory, this plugin will use that instead.


6 changes: 6 additions & 0 deletions lib/git.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ async function saveChangesToPomXml (context, versionStr) {
logger.log('INFO: no multi-project pom.xml files found to add to commit')
}

if (options.additionalFilesToCommit !== undefined && options.additionalFilesToCommit.length > 0) {
logger.log('adding additional files to commit: ' + options.additionalFilesToCommit)
const additionalFiles = options.additionalFilesToCommit.split(',')
await add(additionalFiles, execaOpts)
}

logger.log('committing changes')
await commit(commitMessage, execaOpts)
process.stdout.write('\n')
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"xml2js-es6-promise": "^1.1.1"
},
"devDependencies": {
"mastarm": "^4.1.0",
"mastarm": "^5.1.3",
"semantic-release": "^15.12.3"
},
"peerDependencies": {
Expand Down
Loading

0 comments on commit 03e3511

Please sign in to comment.