Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix release #172

Merged
merged 14 commits into from
Jan 3, 2019
Merged

Bugfix release #172

merged 14 commits into from
Jan 3, 2019

Conversation

evansiroky
Copy link
Contributor

Create a new bugfix release.

Fixes:

landonreed and others added 14 commits October 11, 2018 17:08
Take some reasonable changes that came out of #144 and add them here
at first I thought this was the first calendar date from the calendar_dates.txt file, but then I realized it was actually a result of calculating actual service of various days.  Renaming this variable should reflect this distinction and avoid future confusion.
Fix duplicated schedule exceptions issue with multimap
Conflicts:
	src/test/resources/snapshots/com/conveyal/gtfs/graphql/GTFSGraphQLTest/canFetchErrors.json
Handle zero hops separately if all travel times in feed are rounded
@codecov-io
Copy link

Codecov Report

Merging #172 into master will increase coverage by 0.23%.
The diff coverage is 61.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
+ Coverage     55.32%   55.56%   +0.23%     
- Complexity      737      749      +12     
============================================
  Files           143      143              
  Lines          7190     7311     +121     
  Branches        830      862      +32     
============================================
+ Hits           3978     4062      +84     
- Misses         2874     2899      +25     
- Partials        338      350      +12
Impacted Files Coverage Δ Complexity Δ
.../com/conveyal/gtfs/validator/ValidationResult.java 85.71% <ø> (ø) 1 <0> (ø) ⬇️
.../com/conveyal/gtfs/validator/ServiceValidator.java 82.45% <ø> (ø) 25 <0> (ø) ⬇️
...ava/com/conveyal/gtfs/validator/TripValidator.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...in/java/com/conveyal/gtfs/validator/Validator.java 64.28% <0%> (-17.54%) 4 <0> (ø)
.../java/com/conveyal/gtfs/error/SQLErrorStorage.java 71.91% <0%> (-3.39%) 12 <0> (ø)
...om/conveyal/gtfs/graphql/fetchers/FeedFetcher.java 79.16% <100%> (+0.9%) 4 <0> (ø) ⬇️
...java/com/conveyal/gtfs/error/NewGTFSErrorType.java 100% <100%> (ø) 2 <0> (ø) ⬇️
.../com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java 82.6% <100%> (-0.73%) 26 <0> (ø)
...in/java/com/conveyal/gtfs/graphql/GraphQLUtil.java 96.29% <100%> (ø) 6 <0> (ø) ⬇️
...a/com/conveyal/gtfs/graphql/GraphQLGtfsSchema.java 98.25% <100%> (ø) 1 <0> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40366ed...cab706f. Read the comment docs.

@landonreed landonreed merged commit 94ea5f7 into master Jan 3, 2019
@landonreed
Copy link
Contributor

🎉 This PR is included in version 4.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants