Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-ui): cxl-marketing-nav menu bar button alignment #440

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Nov 27, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt November 27, 2024 17:26
@anoblet anoblet self-assigned this Nov 27, 2024
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.78 KB (+0.06% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 15.04 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.23 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 157.96 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 291.44 KB (+0.01% 🔺)

Copy link

Visit the preview URL for this PR (updated for commit d857a99):

https://aybolit-449f1--pr440-anoblet-fix-menu-bar-9ex3cfvq.web.app

(expires Wed, 04 Dec 2024 17:28:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ebc08d8a89b4eb54ebfb0bb50bd15f151f1243f5

@pawelkmpt pawelkmpt merged commit 2889eb2 into master Dec 16, 2024
7 checks passed
@pawelkmpt pawelkmpt deleted the anoblet/fix/menu-bar branch December 16, 2024 16:47
@lkraav
Copy link

lkraav commented Dec 16, 2024

https://app.clickup.com/t/86b2hv84w

I don't see an end result screenshot anywhere, and preview env is gone. Can someone post?

@anoblet
Copy link
Collaborator Author

anoblet commented Dec 16, 2024

Logo:
image
Menu:
image

@anoblet
Copy link
Collaborator Author

anoblet commented Dec 16, 2024

I noticed that this change should also apply to desktop. I opened a new PR: #442.

@lkraav
Copy link

lkraav commented Dec 16, 2024

I noticed that his change should also apply to desktop. I opened a new PR: #442.

Yep exactly that's why screenshotting in PRs remains a good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants