Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-lumo-styles): allow resource editing page to use full height #439

Closed
wants to merge 1 commit into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Nov 11, 2024

@anoblet anoblet requested review from lkraav and pawelkmpt November 11, 2024 15:55
@anoblet anoblet self-assigned this Nov 11, 2024
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 44.75 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 15.04 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 29.23 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 157.96 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 291.42 KB (0%)

Copy link

Visit the preview URL for this PR (updated for commit 2834b3b):

https://aybolit-449f1--pr439-anoblet-fix-editor-dcguwr69.web.app

(expires Mon, 18 Nov 2024 15:58:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ebc08d8a89b4eb54ebfb0bb50bd15f151f1243f5

Copy link

@lkraav lkraav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking such ephemeral non-testable stuff should go into some cxl-wpstarter corner.

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkraav is right. It should not be in aybolit. Please create mu-plugin, use https://developer.wordpress.org/reference/hooks/admin_print_styles/ hook and print styles there.

Test on WPS and make sure custom styles which are fixing issue on the live site, don't break working stuff on WPS.

MU-plugins are being loaded in the public/wp-content/mu-plugins/wpstarter-mu-loader.php file on WPS. You need to add the path to the newly created plugin in order to load it.

@anoblet anoblet closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants