Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): cxl-dashboard-section info area, stats count updates #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HenerHoop
Copy link

Copy link

github-actions bot commented Dec 13, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 68.96 KB (+0.24% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.16 KB (+0.02% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 136.06 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 246.24 KB (+0.07% 🔺)

@HenerHoop HenerHoop marked this pull request as ready for review December 13, 2023 07:41
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these going to appear in the dashboard automatically or we can control it with the backend code?

Screenshot 2023-12-13 at 10 50 38
Screenshot 2023-12-13 at 10 50 43

@HenerHoop
Copy link
Author

Are these going to appear in the dashboard automatically or we can control it with the backend code?

Screenshot 2023-12-13 at 10 50 38 Screenshot 2023-12-13 at 10 50 43

We can control it with the back end code. This control is already added.

Copy link

@freudFlintstone freudFlintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really match the design, but I'm not in the loop . Maybe the target design is outdated, or the storybook?
Screenshot from 2023-12-13 11-24-26
Screenshot from 2023-12-13 11-25-39

@HenerHoop HenerHoop force-pushed the hener/feat/course-complete-page branch from 5544199 to c26cc3b Compare December 14, 2023 11:28
@HenerHoop
Copy link
Author

It doesn't really match the design, but I'm not in the loop . Maybe the target design is outdated, or the storybook? Screenshot from 2023-12-13 11-24-26 Screenshot from 2023-12-13 11-25-39

@freudFlintstone Image under the task was taken at some point, but the design has received updates/changes. Figma is always a more reliable place to look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants