Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cxl-ui): add cxl-dashboard-section component #348

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

freudFlintstone
Copy link

@freudFlintstone freudFlintstone commented Oct 24, 2023

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 65.13 KB (+1.43% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.76 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 241.49 KB (+0.39% 🔺)

@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch 2 times, most recently from d777083 to 138ebe5 Compare October 24, 2023 02:14
@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 138ebe5 to f6f5500 Compare October 25, 2023 18:31
@freudFlintstone freudFlintstone marked this pull request as ready for review October 25, 2023 19:43
@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 11bea04 to 75d574b Compare October 26, 2023 12:59
Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all commits and change message to

feat(cxl-ui): add cxl-dashboard-section component

https://app.clickup.com/t/86ayj5cv3

@pawelkmpt pawelkmpt changed the title feat(cxl-ui): remove accordion and improve dashboard visual architecture feat(cxl-ui): add cxl-dashboard-section component Oct 31, 2023
@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 75d574b to 41b5226 Compare October 31, 2023 22:31
@heshfekry
Copy link

@HenerHoop HenerHoop force-pushed the raphael/feat/dashboard/no-accordion branch from 41b5226 to 58bd7eb Compare November 1, 2023 10:25
@HenerHoop
Copy link

HenerHoop commented Nov 1, 2023

@freudFlintstone Category header has a fixed height issue and full width description should be limited to a specific width.

Screenshot 2023-11-01 at 12 51 06

@pawelkmpt
Copy link

Squash all commits and change message to

feat(cxl-ui): add cxl-dashboard-section component

https://app.clickup.com/t/86ayj5cv3

@freudFlintstone please read comments carefully. You didn't update commit message

@HenerHoop
Copy link

Squash all commits and change message to

feat(cxl-ui): add cxl-dashboard-section component

https://app.clickup.com/t/86ayj5cv3

@freudFlintstone please read comments carefully. You didn't update commit message

@pawelkmpt It could also have been caused by me because we had a small error there.

@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 58bd7eb to 3d5db89 Compare November 2, 2023 11:43
@freudFlintstone
Copy link
Author

commit message edited

@pawelkmpt
Copy link

@freudFlintstone Category header has a fixed height issue and full width description should be limited to a specific width.

Screenshot 2023-11-01 at 12 51 06

Is this @HenerHoop will work on now?

@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 3d5db89 to 40bf0fd Compare November 2, 2023 20:28
@pawelkmpt
Copy link

@freudFlintstone please solve conflicts. They appeared after recent merges

@freudFlintstone freudFlintstone force-pushed the raphael/feat/dashboard/no-accordion branch from 40bf0fd to b89d4cc Compare November 7, 2023 13:24
@pawelkmpt pawelkmpt merged commit 12b3c34 into master Nov 8, 2023
4 checks passed
@pawelkmpt
Copy link

@pawelkmpt pawelkmpt deleted the raphael/feat/dashboard/no-accordion branch January 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants