Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-ui): adjust cxl-course-card max-width in vaadion-accordion #345

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

freudFlintstone
Copy link

https://app.clickup.com/t/86ayfxnan

It was necessary to limit the card width considering the padding of the cxl-section element, which is wrapping the accordion.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.63 KB (+0.08% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.66 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.89 KB (+0.03% 🔺)

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WPS with this branch. Issue on the specific width

Screenshot 2023-10-17 at 16 25 11

@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/card-responsiveness branch from a32f37a to a94b7e5 Compare October 19, 2023 01:00
Copy link
Author

@freudFlintstone freudFlintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in chrome and firefox, with wpstarter master branch, on multiples widths
Screenshot from 2023-10-18 21-59-07

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well now. I just have a visual tweak. I think card padding on mobile should be changed:

- var(--lumo-space-m) var(--lumo-space-l)
+ var(--lumo-space-m) var(--lumo-space-m)

NOW
Screenshot 2023-10-19 at 09 27 07

TWEAKED
Screenshot 2023-10-19 at 09 27 32

@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/card-responsiveness branch from a94b7e5 to 8dfe2b6 Compare October 19, 2023 13:08
Copy link
Author

@freudFlintstone freudFlintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed padding, added updated story for testing

@freudFlintstone freudFlintstone force-pushed the raphael/fix/dashboard/card-responsiveness branch from 8dfe2b6 to 83691a9 Compare October 19, 2023 13:20
@pawelkmpt pawelkmpt merged commit 7c3802e into master Oct 20, 2023
@pawelkmpt pawelkmpt deleted the raphael/fix/dashboard/card-responsiveness branch October 20, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants